[material_ui] Copies a11y_assessments - #12686
Conversation
github-actions
Bot
added
platform-android
platform-ios
platform-linux
platform-macos
platform-web
platform-windows
p: material_ui
triage-design
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Flutter project, a11y_assessments, designed for accessibility testing across multiple platforms including Android, iOS, Linux, macOS, Web, and Windows. It implements a wide range of widget use cases to assess accessibility compliance, along with corresponding tests. Feedback on the changes highlights a potential compilation issue in utils.cpp due to the use of a non-standard macro UNICODE_STRING_MAX_CHARS, and identifies several unused variables in action_chip.dart, card.dart, and navigation_drawer.dart that should be removed.
chunhtai
added
override: no versioning needed
|
reason for override: this is a sample app that won't be include in the release. |
QuncCccccc
left a comment
QuncCccccc
left a comment
There was a problem hiding this comment.
LGTM. Just have a question, I saw the original app in flutter/flutter also have a GEMINI.md file, is it for agent learning? Just curious whether we also want that in material_ui.
I have no idea how it works, I think that is for gemini code assist, and I am not sure if it still working because the tech change fast. I will defer that to your team, but for now, I removed that file because packages repro doesn't have the same convention. |
|
We should pubignore this directory so it's not released with I also wonder if it would make sense to add it in a subdirectory (e.g. @QuncCccccc what are your thoughts here? |
|
Both suggestions make sense to me! |
|
ok i will put it in test_apps |
e6fb86f to
036f7b1
Compare
3 participants
as title.
Move the app in material give use benefit that we can both fix accessibility issue and verify the fix on the app faster without waiting for a release cycle
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2